[libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

[Michal Privoznik]

On 9/2/19 4:16 PM, Daniel P. Berrangé wrote:
> On Mon, Sep 02, 2019 at 02:07:08PM +0000, Jim Fehlig wrote:
>> On 8/31/19 2:11 AM, Michal Prívozník  wrote:
>>> On 8/26/19 1:49 PM, Ján Tomko wrote:
>>>> The 'From:' field shows your e-mail in uppercase.
>>>>
>>>> On Fri, Aug 23, 2019 at 07:50:12PM +0000, Jim Fehlig wrote:
>>>>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>>>>> ---
>>>>> cfg.mk                                   |  2 +-
>>>>> configure.ac                             |  2 --
>>>>> po/POTFILES                              |  6 ++---
>>>>> src/Makefile.am                          |  1 -
>>>>> src/libvirt_xenconfig.syms               | 12 ----------
>>>>> src/libxl/Makefile.inc.am                | 25 ++++++---------------
>>>>> src/{xenconfig => libxl}/xen_common.c    |  0
>>>>> src/{xenconfig => libxl}/xen_common.h    |  0
>>>>> src/{xenconfig => libxl}/xen_xl.c        |  0
>>>>> src/{xenconfig => libxl}/xen_xl.h        |  0
>>>>> src/{xenconfig => libxl}/xen_xm.c        |  0
>>>>> src/{xenconfig => libxl}/xen_xm.h        |  0
>>>>> src/{xenconfig => libxl}/xenxs_private.h |  0
>>>>> src/xenconfig/Makefile.inc.am            | 28 ------------------------
>>>>> tests/xlconfigtest.c                     |  2 +-
>>>>> tests/xmconfigtest.c                     |  2 +-
>>>>> 16 files changed, 13 insertions(+), 67 deletions(-)
>>>>>
>>>>
>>>
>>> Actually, this breaks --with-xenapi build:
>>>
>>> xenapi/xenapi_driver.c:38:10: fatal error: xen_common.h: No such file or
>>> directory
>>>    #include "xen_common.h"
>>>             ^~~~~~~~~~~~~~
>>> compilation terminated.
>>
>> Can you determine why this is needed? E.g. remove it and see what subsequently
>> fails? I don't have a setup readily available to test a xenapi build (I'm not
>> "in the office" today as it is a US holiday).
> 
> I'm inclined to say that we should call the XenAPI driver dead at
> this point. IIUC, the person at Citrix who wrote left, left that
> job shortly after it was merged into libvirt. Looking at the git
> history I'm struggling to see any single patch applied in 9 years
> since that was not a general cleanup/bugfix. The XML handling does
> not deal with disks at all AFAICT making it largely useless.
> 
> IOW, lets just document that it fails to build for this release
> and then delete its code.

Agreed.

Michal