[libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

[Pino Toscano]

On Tuesday, 3 September 2019 11:07:36 CEST Andrea Bolognani wrote:
> On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote:
> > This ensures that the MANIFEST file is up-to-date, and thus dist will
> > (hopefully) work.
> > 
> > Signed-off-by: Pino Toscano <ptoscano at redhat.com>
> > ---
> >  guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
> >  jenkins/projects/libvirt-ocaml.yaml               | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml b/guests/playbooks/build/projects/libvirt-ocaml.yml
> > index 7a2e216..d293738 100644
> > --- a/guests/playbooks/build/projects/libvirt-ocaml.yml
> > +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
> > @@ -25,3 +25,4 @@
> >        ./configure --prefix=$VIRT_PREFIX
> >        $MAKE
> >        $MAKE opt
> > +      $MAKE check-manifest
> 
> Wouldn't it make sense to have a separate libvirt-ocaml-check job for
> this?

Right now both the yaml files have a single job doing all the build
commands.  Since it uses autoconf but not the rest of autotools, and
it does not support VPATH builds, then I created a simple custom job.

> Also, does libvirt-ocaml have a test suite we could run as part
> of that job?

Unfortunately not.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190903/fadd4175/attachment-0001.sig>