[libvirt] [PATCH 00/11] scripts: convert many scripts from perl to python

[Ján Tomko]

On Thu, Sep 05, 2019 at 11:21:55AM +0100, Daniel P. Berrangé wrote:
[snipping the zoo]

>
>Daniel P. Berrangé (11):
>  cfg.mk: fix comment detection for python semicolon check
>  docs: rewrite hvsupport.html page generator in python
>  docs: rewrite ACL permissions checker in Python
>  docs: rewrite symfile sorting checker in Python
>  docs: rewrite symfile library checker in Python
>  docs: rewrite augest test generator in Python
>  docs: rewrite po file minimizer in Python
>  docs: rewrite duplicate header checker in Python
>  docs: rewrite whitespace checker in Python
>  docs: rewrite mock inline checker in Python
>  docs: rewrite header ifdef checker in Python
>

As I said in RE: Language Consolidation,
this could use a preceding HACKING change with justification.

Also, rewrite to a new language does mean throwing away debugged and
optimized code - but if the end goal is to drop automake and configure,
overall the build will be much quicker anyway.

Also, this does not work with Python 3.6 on my Gentoo:
Traceback (most recent call last):
  File "./build-aux/prohibit-duplicate-header.py", line 48, in <module>
    if check_file(filename):
  File "./build-aux/prohibit-duplicate-header.py", line 30, in check_file
    for line in fh:
  File "/usr/lib/python-exec/python3.6/../../../lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 548: ordinal not in range(128)
makefile_conditionals
po_check
preprocessor_indentation
prohibit_HAVE_MBRTOWC
make: *** [cfg.mk:1150: prohibit-duplicate-header] Error 123
make: *** Waiting for unfinished jobs....
prohibit_PATH_MAX
Traceback (most recent call last):
  File "./build-aux/header-ifdef.py", line 203, in <module>
    if check_header(filename):
  File "./build-aux/header-ifdef.py", line 85, in check_header
    for line in fh:
  File "/usr/lib/python-exec/python3.6/../../../lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 100: ordinal not in range(128)
make: *** [cfg.mk:1163: header-ifdef] Error 123
Traceback (most recent call last):
  File "./build-aux/mock-noinline.py", line 76, in <module>
    scan_annotations(filename)
  File "./build-aux/mock-noinline.py", line 39, in scan_annotations
    for line in fh:
  File "/usr/lib/python-exec/python3.6/../../../lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 100: ordinal not in range(128)
make: *** [cfg.mk:1159: mock-noinline] Error 123
Traceback (most recent call last):
  File "./build-aux/check-spacing.py", line 201, in <module>
    if check_whitespace(filename):
  File "./build-aux/check-spacing.py", line 59, in check_whitespace
    for line in fh:
  File "/usr/lib/python-exec/python3.6/../../../lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 548: ordinal not in range(128)
maint.mk: incorrect formatting
make: *** [cfg.mk:1154: spacing-check] Error 1

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190905/2c02d010/attachment-0001.sig>