[libvirt] [PATCH v3 09/18] qemu: driver: Fix shallow non-reuse block copy

[Ján Tomko]

On Tue, Sep 03, 2019 at 04:08:02PM +0200, Peter Krempa wrote:
>The code preparing data for creating/attaching the target image of block
>copy didn't use the correct reference to the existing backing chain in
>case when the copy should inherit it. This meant that qemu actually
>opened a second copy of the chain and operated on that.
>
>This would de-sync qemu from libvirt's view of node names. Luckily this
>is only hypothetical at this point since it happens only when -blockdev
>is enabled.

Phew

>
>Fix it by passing 'mirrorBacking' which has the proper data as the
>backing store when calling
>qemuBuildStorageSourceChainAttachPrepareBlockdevTop.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190905/73613ff0/attachment-0001.sig>