[libvirt] [PATCH v3 10/18] qemu: snapshot: Fix image lock handling when taking a snapshot

Ján Tomko jtomko at redhat.com
Thu Sep 5 13:54:21 UTC 2019


On Tue, Sep 03, 2019 at 04:08:03PM +0200, Peter Krempa wrote:
>When we take a snapshot we must properly remove our locking
>infrastructure locks. This was broken by commit 3817fa10c4ad9 which
>attempted to properly track the readonly state for the image as the
>locking code was executed after this change. Since we forced the image
>which was locked as read-write to read-only prior to unlocking it the
>write lock was not dropped.
>
>Fix it by moving the locking code prior to modifying the readonly flag.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1745618
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190905/6333cc0f/attachment-0001.sig>


More information about the libvir-list mailing list