[libvirt] [PATCH 01/11] cfg.mk: fix comment detection for python semicolon check

[Eric Blake]

On 9/5/19 5:21 AM, Daniel P. Berrangé wrote:
> The pattern
> 
>     ^[^#].*\;$$
> 
> Was attempting to detect any trailing ';' in python code
> which was not in a comment. This does not allow for the
> comment '#' character to be indented with whitespace.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  cfg.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 1f29729949..d10dfa16a1 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -815,7 +815,7 @@ sc_require_enum_last_marker:
>  
>  # In Python files we don't want to end lines with a semicolon like in C
>  sc_prohibit_semicolon_at_eol_in_python:
> -	@prohibit='^[^#].*\;$$' \
> +	@prohibit='^[^#]*\;$$' \

But this new pattern does not prohibit:

 ch = '#';

I think you want:

'^[ \t]*[^#].*\;$$'

to flag all lines that have any amount of leading whitespace, where the
first non-whitespace is not #, and which end in ;.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190905/2bee59d9/attachment-0001.sig>