[libvirt] [PATCH v1 0/3] small code repetition purge on qemu_conf.c

[Pavel Hrdina]

On Tue, Sep 03, 2019 at 08:06:04PM -0300, Daniel Henrique Barboza wrote:
> Stumbled on this while changing qemu_conf.c for other
> reasons. Moved code around here and there to avoid
> repetition.
> 
> Final result is 23 less lines for the same functionality,
> which is nothing to write home about but seems okay
> to contribute.
> 
> 
> Daniel Henrique Barboza (3):
>   qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal
>   qemu_conf.c: introduce qemuAddRemoveSharedDiskInternal
>   qemu_conf.c: introduce qemuAddRemoveSharedDeviceInternal
> 
>  src/qemu/qemu_conf.c | 193 +++++++++++++++++++------------------------
>  1 file changed, 85 insertions(+), 108 deletions(-)

Feel free to ignore my comment about the Internal name as it makes sense
with the last patch.  I'll fix the parameter to be on its own line and
push it, thanks.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190909/a78ad5b5/attachment-0001.sig>