[libvirt] [PATCH] domain_conf: Drop ancient reservation of unit 7 in drive address

[Daniel Henrique Barboza]

On 8/28/19 6:52 AM, Michal Privoznik wrote:
> Introduced in v1.0.6~3, the idea was that unit 7 was reserved and
> couldn't be used by QEMU. Well, that limitation is long gone.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>


>   src/conf/domain_conf.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index b7a342bb91..6a019490fd 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -4812,12 +4812,6 @@ bool
>   virDomainSCSIDriveAddressIsUsed(const virDomainDef *def,
>                                   const virDomainDeviceDriveAddress *addr)
>   {
> -    /* In current implementation, the maximum unit number of a controller
> -     * is either 16 or 7 (narrow SCSI bus), and if the maximum unit number
> -     * is 16, the controller itself is on unit 7 */
> -    if (addr->unit == 7)
> -        return true;
> -
>       if (virDomainDriveAddressIsUsedByDisk(def, VIR_DOMAIN_DISK_BUS_SCSI,
>                                             addr) ||
>           virDomainDriveAddressIsUsedByHostdev(def,