[libvirt] [PATCH v2 02/24] cfg.mk: fix comment detection for python semicolon check
Daniel P. Berrangé
berrange at redhat.com
Wed Sep 11 16:23:11 UTC 2019
The pattern
^[^#].*\;$$
Was attempting to detect any trailing ';' in python code
which was not in a comment. This does not allow for the
comment '#' character to be indented with whitespace.
Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cfg.mk b/cfg.mk
index 1f29729949..d09ab507e0 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -815,7 +815,7 @@ sc_require_enum_last_marker:
# In Python files we don't want to end lines with a semicolon like in C
sc_prohibit_semicolon_at_eol_in_python:
- @prohibit='^[^#].*\;$$' \
+ @prohibit='^[ \t]*[^# \t].*\;$$' \
in_vc_files='\.py$$' \
halt='python does not require to end lines with a semicolon' \
$(_sc_search_regexp)
--
2.21.0
More information about the libvir-list
mailing list