[libvirt] [PATCH 2/4] virt-result.m4: Align string more generously

[Daniel P. Berrangé]

On Thu, Sep 12, 2019 at 12:18:10PM +0200, Michal Privoznik wrote:
> On 9/12/19 12:30 AM, Cole Robinson wrote:
> > On 9/9/19 3:49 AM, Michal Privoznik wrote:
> > > The times, when we had small CRTs are long gone. Now, in the era
> > > of wide screens we can be more generous when it comes to aligning
> > > the output of configure. The longest string before the colon is
> > > 'wireshark_dissector' which counts 19 characters.  Therefore,
> > > align the strings at 20.
> > > 
> > > At the same time, drop the useless result alignment. It behaves
> > > oddly - it puts a space at the end of each "no" because of the
> > > %-3s format we use.
> > > 
> > > Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> > > ---
> > >   m4/virt-result.m4 | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/m4/virt-result.m4 b/m4/virt-result.m4
> > > index cc622fe35b..36973ba0b5 100644
> > > --- a/m4/virt-result.m4
> > > +++ b/m4/virt-result.m4
> > > @@ -33,9 +33,9 @@ dnl  LIBVIRT_RESULT([yajl], [yes], [-I/opt/yajl/include -lyajl])
> > >   dnl
> > >   AC_DEFUN([LIBVIRT_RESULT], [
> > >     if test "$2" = "no" || test -z "$3" ; then
> > > -    STR=`printf "%10s: %-3s" "$1" "$2"`
> > > +    STR=`printf "%20s: %s" "$1" "$2"`
> > >     else
> > > -    STR=`printf "%10s: %-3s (%s)" "$1" "$2" "$3"`
> > > +    STR=`printf "%20s: %s (%s)" "$1" "$2" "$3"`
> > >     fi
> > >     AC_MSG_NOTICE([$STR])
> > > 
> > 
> > For the first 2:
> > 
> > Reviewed-by: Cole Robinson <crobinso at redhat.com>
> > 
> > I like the look of the colors and I agree it speeds up visually scanning
> > the configure output. But I'm neutral on whether adding more m4 to the
> > build system to facilitate it is worth it. So I'll abstain from giving
> > ack or nack on those.
> 
> Fair enough. When we switch to meson we'll get colours for free.

FWIW, I've no objection to people continuing to make autotools
usage better. In it unreasonable to block patches people send,
until the meson patches are actually complete & published for
review. I merely caution that any investment has a time limited
window for payback, but since you've already done the work that's
not a problem.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|