[libvirt] [PATCH 0/2] qemu: Fix blockjob assignment collision (blockdev-add saga)

[Martin Kletzander]

On Sat, Sep 14, 2019 at 10:43:59AM +0200, Peter Krempa wrote:
>We leaked a block job object in the tests because two jobs with distinct
>names referenced the same disk. Fix the test data and add code to
>prevent this issue.
>

This makes way more sense than the patch form Michal, so I prefer this version.
The fact that it gets triggered by an invalid test made me think that it is not
possible to cause in a real life scenario, but I could not find a place where it
would actually allow this to happen in a normal user workflow.  But I'm not that
familiar with that part of the codebase.  Feel free to consider this also

  Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

With what Erik pointed out, but I would really, *really* like to know the answer
to his question as I would like to know how wrong I was with my hypothesis ;-)

>Peter Krempa (2):
>  tests: qemustatusxml2xml: Fix disk target mess
>  qemu: blockjob: Refuse to register blockjob if disk already has one
>
> src/qemu/qemu_blockjob.c                           |  6 ++++++
> .../qemustatusxml2xmldata/blockjob-blockdev-in.xml | 14 +++++++-------
> 2 files changed, 13 insertions(+), 7 deletions(-)
>
>-- 
>2.21.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190915/13a07cfa/attachment-0001.sig>