[libvirt] [PATCH 5/5] virsh: Don't open-code virJSONStringReformat in cmdQemuMonitorCommand
Daniel Henrique Barboza
danielhb413 at gmail.com
Tue Sep 17 14:10:51 UTC 2019
On 9/16/19 9:45 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> tools/virsh-domain.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 8c24935938..fbfdc09c0d 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -9512,7 +9512,6 @@ cmdQemuMonitorCommand(vshControl *ctl, const vshCmd *cmd)
> unsigned int flags = 0;
> const vshCmdOpt *opt = NULL;
> virBuffer buf = VIR_BUFFER_INITIALIZER;
> - VIR_AUTOPTR(virJSONValue) pretty = NULL;
>
> VSH_EXCLUSIVE_OPTIONS("hmp", "pretty");
>
> @@ -9538,8 +9537,7 @@ cmdQemuMonitorCommand(vshControl *ctl, const vshCmd *cmd)
>
> if (vshCommandOptBool(cmd, "pretty")) {
> char *tmp;
> - pretty = virJSONValueFromString(result);
> - if (pretty && (tmp = virJSONValueToString(pretty, true))) {
> + if ((tmp = virJSONStringReformat(result, true))) {
> VIR_FREE(result);
> result = tmp;
> virTrimSpaces(result, NULL);
More information about the libvir-list
mailing list