[libvirt] [PATCH v4 20/20] tests: add vhost-user-gpu xml2argv tests
Cole Robinson
crobinso at redhat.com
Fri Sep 20 21:10:42 UTC 2019
On 9/13/19 8:50 AM, marcandre.lureau at redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
> ...host-user-gpu-secondary.x86_64-latest.args | 43 +++++++++++++++++
> .../vhost-user-gpu-secondary.xml | 46 +++++++++++++++++++
> .../vhost-user-vga.x86_64-latest.args | 40 ++++++++++++++++
> tests/qemuxml2argvdata/vhost-user-vga.xml | 42 +++++++++++++++++
> tests/qemuxml2argvtest.c | 3 ++
> 5 files changed, 174 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/vhost-user-gpu-secondary.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/vhost-user-gpu-secondary.xml
> create mode 100644 tests/qemuxml2argvdata/vhost-user-vga.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/vhost-user-vga.xml
For 15-20:
Reviewed-by: Cole Robinson <crobinso at redhat.com>
git log says you have commit access, so I think this series is fine to
push with:
- patch #2 split out and changed+submitted separately
- Jano's comments addressed
- the cgroup crasher fixed. just ignore my comment about the function rename
- Send a follow up patch to fix the error reporting in qemu_vhost_user_gpu.c
As for testing the rendernode allocation, virHostGetDRMRenderNode is
mocked in tests/qemuxml2argvmock.c, and the test case
./tests/qemuxml2argvdata/graphics-spice-gl-auto-rendernode.xml triggers
that mocking, so maybe something similar can be done for vhost-user
- Cole
More information about the libvir-list
mailing list