[libvirt] [PATCH 3/3] qemu_hotplug.c: use VIR_AUTOFREE() in strings 3/3

Erik Skultety eskultet at redhat.com
Mon Sep 23 07:36:29 UTC 2019


On Wed, Sep 18, 2019 at 04:53:08PM -0300, Daniel Henrique Barboza wrote:
> Using VIR_AUTOFREE() spare us from calling VIR_VREE() and
> sometimes a whole 'cleanup' label can be erased as well.
>
> There are quite a few strings in qemu_hotplug.c to be
> auto-freed. This is the last part of this change.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---

I think that since all 3 patches are touching the same module, all of them can
be squashed into 1 (for review purposes the split was good though).

I'll fix the nits I raised in 1 and 2, squash, adjust the commit message and
push.

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list