[libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

[Pavel Hrdina]

On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote:
> On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote:
> > > For what it's worth, I also prefer 'syntax': the -check suffix is
> > > useful for make because it highlights that you're verifying some
> > > property of the program, and also clearly ties
> > > 
> > >   make check
> > >   make syntax-check
> > > 
> > > together. In the case of Meson, the fact that you're verifying
> > > something is explicit in the name of the ninja target, and also
> > > 
> > >   ninja test --suite unit
> > >   ninja test --suite syntax
> > > 
> > > are already very obviously connected. Using 'syntax-check' for the
> > > latter would, if anything, make the relationship unbalanced: why
> > > didn't we call the former 'unit-check' then?
> > 
> > How about calling the suite "style" rather than "syntax" since I
> > think that better reflects what it is actually doing. It is coding
> > style / guidelines checks.
> 
> Sounds good to me!

Works for me as well.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190923/684b97c2/attachment-0001.sig>