[libvirt] [PATCH 01/22] util: typedparam: Split out public APIs into a separate file

Ján Tomko jtomko at redhat.com
Mon Sep 23 15:34:02 UTC 2019


On Thu, Sep 19, 2019 at 07:13:04PM +0200, Peter Krempa wrote:
>Some of the typed parameter APIs are exported publically, but the

publicly is the more common spelling

>implementation was intermixed with private functions. Introduce
>virtypedparam-public.c, move all public API functions there and purge
>the comments stating that some functions are public.
>
>This will decrease the likelyhood of messing up the expectations as well

likelihood

>as it will become more clear which of them are actually public.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> docs/Makefile.am                |   2 +-
> docs/apibuild.py                |   2 +-
> src/util/Makefile.inc.am        |   1 +
> src/util/virtypedparam-public.c | 795 ++++++++++++++++++++++++++++++++
> src/util/virtypedparam.c        | 775 -------------------------------
> 5 files changed, 798 insertions(+), 777 deletions(-)
> create mode 100644 src/util/virtypedparam-public.c
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190923/b4865c89/attachment-0001.sig>


More information about the libvir-list mailing list