[libvirt] [PATCH 2/8] qemu: checkpoint: Remove open-ended TODOs

Peter Krempa pkrempa at redhat.com
Thu Sep 26 15:51:06 UTC 2019


Once somebody is motivated enough to add the support for the quiesce
flag or offline checkpoint deletion they are welcome to do so but we
don't need to have a reminder.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_checkpoint.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 4430f69911..59f700e1d3 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -370,7 +370,6 @@ qemuCheckpointCreateXML(virDomainPtr domain,
     VIR_AUTOUNREF(virDomainCheckpointDefPtr) def = NULL;

     virCheckFlags(VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE, NULL);
-    /* TODO: VIR_DOMAIN_CHECKPOINT_CREATE_QUIESCE */

     if (redefine) {
         parse_flags |= VIR_DOMAIN_CHECKPOINT_PARSE_REDEFINE;
@@ -570,8 +569,6 @@ qemuCheckpointDelete(virDomainObjPtr vm,
         return -1;

     if (!metadata_only) {
-        /* Until qemu-img supports offline bitmap deletion, we are stuck
-         * with requiring a running guest */
         if (!virDomainObjIsActive(vm)) {
             virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                            _("cannot delete checkpoint for inactive domain"));
-- 
2.21.0




More information about the libvir-list mailing list