[libvirt] [PATCH v4 00/12] remove repetition of URI path validation

[Cole Robinson]

On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote:
> This is a code repetition that I crossed a few times, then
> I noticed that Cole Robinson suggested a solution for it
> in the wiki. Here it is.
> 
> 
> changes from v3:
> - patch 8: fix the exception logic, move the code formatting
> to patch 1
> - patch 9: use lowcase 'qemu'
> - patch 12: (optional) test case I created to aid in patch 8
> logic
> 
> changes from v2:
> - use a boolean to determine 'QEMU' and 'vbox' case to avoid block
> repetition (patch 8)
> - avoid 80+ chars lines in all patches
> 
> changes from v1:
> - handle QEMU and vbox cases separately inside the validation
> function
> 
> v3: https://www.redhat.com/archives/libvir-list/2019-September/msg01122.html
> v2: https://www.redhat.com/archives/libvir-list/2019-September/msg01007.html
> v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00983.html
> 
> Daniel Henrique Barboza (12):
>    src/driver.c: add virConnectValidateURIPath()
>    interface_backend_netcf.c: use virConnectValidateURIPath()
>    interface_backend_udev.c: use virConnectValidateURIPath()
>    bridge_driver.c: virConnectValidateURIPath()
>    node_device_driver.c: use virConnectValidateURIPath()
>    secret_driver.c: use virConnectValidateURIPath()
>    storage_driver.c: use virConnectValidateURIPath()
>    driver.c: change URI validation to handle QEMU and vbox case
>    qemu_driver.c: use virConnectValidateURIPath()
>    vbox_common.c: use virConnectValidateURIPath()
>    vbox_driver.c: use virConnectValidateURIPath()
>    tests: add a test for driver.c:virConnectValidateURIPath()
> 
>   src/driver.c                            |  38 +++++
>   src/driver.h                            |   4 +
>   src/interface/interface_backend_netcf.c |  19 +--
>   src/interface/interface_backend_udev.c  |  19 +--
>   src/libvirt_private.syms                |   1 +
>   src/network/bridge_driver.c             |  19 +--
>   src/node_device/node_device_driver.c    |  19 +--
>   src/qemu/qemu_driver.c                  |  20 +--
>   src/secret/secret_driver.c              |  19 +--
>   src/storage/storage_driver.c            |  19 +--
>   src/vbox/vbox_common.c                  |  16 +-
>   src/vbox/vbox_driver.c                  |  16 +-
>   tests/Makefile.am                       |   7 +-
>   tests/virdriverconnvalidatetest.c       | 186 ++++++++++++++++++++++++
>   14 files changed, 267 insertions(+), 135 deletions(-)
>   create mode 100644 tests/virdriverconnvalidatetest.c
> 

I pushed 1-11. I'll review the test suite bits tomorrow

- Cole

- Cole