[libvirt] [PATCH] qemu: ensure vhostuser FD is initialized to -1

Daniel P. Berrangé berrange at redhat.com
Mon Sep 30 11:20:32 UTC 2019


On Sat, Sep 28, 2019 at 10:39:49PM +0200, Michal Prívozník wrote:
> On 9/27/19 6:36 PM, Daniel P. Berrangé wrote:
> > The video private data was not initializing the vhostuser FD
> > causing us to attempt to close FD 0 many times over.
> > 
> > Fixes
> > 
> >   commit ca60ecfa8cc1bd85baf7137dd1864d5f00f019f0
> >   Author: Marc-André Lureau <marcandre.lureau at redhat.com>
> >   Date:   Mon Sep 23 14:44:36 2019 +0400
> > 
> >       qemu: add qemuDomainVideoPrivate
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/qemu/qemu_domain.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Seems life isn't quite as simple as this.  We break the test suite
as the FD we pass to QEMU is -1 now. 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list