[libvirt] [PATCH 05/11] util: use glib string allocation/formatting functions

[Ján Tomko]

On Mon, Sep 30, 2019 at 10:37:53AM +0200, Peter Krempa wrote:
>On Fri, Sep 27, 2019 at 18:17:27 +0100, Daniel Berrange wrote:
>> Convert the string duplication APIs to use the g_strdup family of APIs.
>>
>> Annoyingly our virVasprintf/virAsprintf functions return the character
>> count, even though 90% of our usage doesn't need it. To retain compat

The actual percentage is way closer to 100%, the only function that
actually uses the return value of virAsprintf is virNWFilterSnoopLeaseFileWrite.

And the only other function needing adjustment is libxlDomainCleanup
where we check for > 0 instead of >= 0 like in other places.

Also, making virAsprintf return 0/-1 will actually fix the return value
of virLogSetDefaultOutput to match its documentation.

Jano

>> with these semantics we have a call to strlen which costs CPU time.
>
>I'd rather refactor the handful of cases which care about the formatted
>length and drop the strlens.
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190930/2af3369f/attachment-0001.sig>