[libvirt] [PATCH v2 2/2] remove a now redundant call to virDiskNameToIndex()

Pavel Mores pmores at redhat.com
Mon Sep 30 13:41:01 UTC 2019


Parseability of disk name is now checked in qemuDomainDeviceDefValidateDisk().

Signed-off-by: Pavel Mores <pmores at redhat.com>
---
 src/qemu/qemu_command.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 77470a6037..890d89b92c 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1290,12 +1290,6 @@ qemuCheckDiskConfig(virDomainDiskDefPtr disk,
     if (qemuCheckDiskConfigBlkdeviotune(disk, qemuCaps) < 0)
         return -1;
 
-    if (virDiskNameToIndex(disk->dst) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("unsupported disk type '%s'"), disk->dst);
-        return -1;
-    }
-
     if (disk->wwn) {
         if ((disk->bus != VIR_DOMAIN_DISK_BUS_IDE) &&
             (disk->bus != VIR_DOMAIN_DISK_BUS_SCSI)) {
-- 
2.21.0




More information about the libvir-list mailing list