[libvirt] [PATCH 2/2] qemu: checkpoint: Don't update current checkpoint until we are done

Peter Krempa pkrempa at redhat.com
Mon Sep 30 14:42:46 UTC 2019


Similarly to the snapshot code there's no reason to modify current
checkpoint until we are done creating the new one.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_checkpoint.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 0d90bbec14..8856a90ce8 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -412,13 +412,6 @@ qemuCheckpointCreateXML(virDomainPtr domain,
         if (!redefine &&
             VIR_STRDUP(chk->def->parent_name, other->def->name) < 0)
             goto endjob;
-        if (update_current) {
-            virDomainCheckpointSetCurrent(vm->checkpoints, NULL);
-            if (qemuCheckpointWriteMetadata(vm, other,
-                                            driver->caps, driver->xmlopt,
-                                            cfg->checkpointDir) < 0)
-                goto endjob;
-        }
     }

     /* actually do the checkpoint */
-- 
2.21.0




More information about the libvir-list mailing list