[libvirt] [PATCH] qemu_capabilities: Put only unique FW images into domcaps

Andrea Bolognani abologna at redhat.com
Mon Sep 30 15:46:12 UTC 2019


On Thu, 2019-09-12 at 15:31 +0200, Michal Privoznik wrote:
> In the domain capabilities XML there are FW image paths printed.
> There are two sources for the image paths (in order of
> preference):
> 
>   1) firmware descriptor files - as returned by
>   qemuFirmwareGetSupported()
> 
>   2) a compile time list of FW:NRAM pairs which can be overridden
>   in qemu.conf
> 
> If either of those contains a duplicate FW image path (which is
> a valid use case) it is printed twice in the capabilities XML.
> While it's technically not a bug, it doesn't look good.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list