[libvirt] [PATCH] admin: fix memory leak of typed parameters getting client info

Daniel P. Berrangé berrange at redhat.com
Mon Sep 30 15:57:14 UTC 2019


In the error code path, the temporary parameters are not freed.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 src/admin/admin_server.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c
index 248df3f795..0d6091937d 100644
--- a/src/admin/admin_server.c
+++ b/src/admin/admin_server.c
@@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client,
     ret = 0;
 
  cleanup:
+    if (tmpparams)
+        virTypedParamsFree(tmpparams, *nparams);
     virObjectUnref(identity);
     VIR_FREE(sock_addr);
     return ret;
-- 
2.21.0




More information about the libvir-list mailing list