[PATCH for 6.2.0] qemuDomainSnapshotDiskPrepareOne: Fix logic of relative backing store update

Ján Tomko jtomko at redhat.com
Thu Apr 2 10:12:38 UTC 2020


On a Thursday in 2020, Peter Krempa wrote:
>Commit 2ace7a87a8aced68c250 introduced a logic bug by an improperly
>modified condition where we'd skip to the else branch when reusing of
>external images was requested and blockdev is available.
>
>The original intentions were to skip the backing store update with
>blockdev.
>
>Fix it by only asserting the boolean which was used to track whether we
>support update of the backing store only when blockdev is not present
>along with the appropriate rename.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1820016
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200402/37435962/attachment-0001.sig>


More information about the libvir-list mailing list