[libvirt PATCH 1/8] daemons: Support --timeout 0

Andrea Bolognani abologna at redhat.com
Thu Apr 2 12:26:28 UTC 2020


On Thu, 2020-04-02 at 13:05 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 01, 2020 at 08:53:38PM +0200, Andrea Bolognani wrote:
> > -    if (timeout != -1) {
> > +    if (timeout > 0) {
> >          VIR_DEBUG("Registering shutdown timeout %d", timeout);
> >          virNetDaemonAutoShutdown(lockDaemon->dmn,
> >                                   timeout);
> 
> This conditional can be removed because virNetDaemonAutoShutdown
> treats "timeout == 0" as meaning no timeout.

Can do, although to be honest I kinda like the current form, with the
debug message only printed when a timeout is actually configured, a
bit better.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list