[libvirt PATCH 4/8] logging, locking: Set default timeout of 120 seconds
abologna at redhat.com
Thu Apr 2 14:04:40 UTC 2020
On Thu, 2020-04-02 at 14:01 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 02:51:13PM +0200, Andrea Bolognani wrote:
> > I started a VM, waited a bit, and sure enough virtlogd quit on its
> > own. However, after I ssh'd into the VM and executed poweroff,
> > virtlogd was socket-activated (as expected) and the log file, which
> > I was tailing from another terminal, was updated to report the fact
> > that the VM was shutting down. So, at least from this very simple
> > test, it would seem that there is no ill effect resulting from
> > letting virtlogd shut itself down after a timeout.
> Anything that QEMU would have written to the logfile is lost
> > However, given the concern you've raised, I would personally err on
> > the side of caution and merge patch 3/8 from this series right away,
> > so that we are sure 6.2.0 is released in a known-good state. Any
> > objection to that?
> Yes, we need to revert that change asap.
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list