[PATCH 03/15] qemu: move qemuDomainValidateDef() to qemu_validate.c

Ján Tomko jtomko at redhat.com
Fri Apr 3 13:33:38 UTC 2020


On a Thursday in 2020, Daniel Henrique Barboza wrote:
>After moving most of static functions qemuDomainValidateDef() uses,
>move the last remaining static and qemuDomainValidateDef() itself
>to qemu_validation.c.

I'd rather squash this with the previous patch.

>
>Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>---
> src/qemu/qemu_domain.c   | 254 +-----------------------------------
> src/qemu/qemu_validate.c | 269 +++++++++++++++++++++++++++++++++++++--
> src/qemu/qemu_validate.h |  19 +--
> 3 files changed, 263 insertions(+), 279 deletions(-)
>
>diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
>index b2a8c3c0b5..27e0558770 100644
>--- a/src/qemu/qemu_validate.c
>+++ b/src/qemu/qemu_validate.c
>+
>+int
>+qemuValidateDomainDef(const virDomainDef *def, void *opaque)

The parameters were originally on different lines.

>+{
>+    virQEMUDriverPtr driver = opaque;
>+    g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
>+    g_autoptr(virQEMUCaps) qemuCaps = NULL;
>+    size_t i;

To this and the previous patch:
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200403/b32ca897/attachment-0001.sig>


More information about the libvir-list mailing list