[libvirt PATCH] github: enable lockdown of issues and merge requests

Ján Tomko jtomko at redhat.com
Fri Apr 3 17:35:12 UTC 2020

On a Friday in 2020, Andrea Bolognani wrote:
>On Fri, 2020-04-03 at 11:38 +0100, Daniel P. Berrangé wrote:
>> +++ b/.github/lockdown.yml
>> @@ -0,0 +1,36 @@
>> +pulls:
>> +  comment: |
>> +    Thank you for your interest in the libvirt project.
>> +
>> +    Since this repository is a read-only mirror of the project's
>>      master repostory hosted on GitLab, merge requests opened here
>>      are not processed.
>Maybe s/merge/pull/ here? Since we're adding a comment on GitHub and
>targeting GitHub users when doing so, it might be more appropriate to
>use the GitHub term.
>Everything else looks good, but there's the obvious caveat that we
>can't merge the commit as-is until we have actually moved to GitLab.
>Since that could take a while, and locking down the GitHub
>repositories is already a good idea, maybe point people to
>  https://libvirt.org/hacking.html
>in the meantime?

As danpb mentions in the cover letter, CONTRIBUTING.md should be easily
discoverable on GitLab. We [0] should somehow put the brief instructions
there (like README-hacking) and not scare drive-by contributors with
the giant hacking.html.

OTOH, I'm not sure how well 'I fixed these coding styles issues and
pushed the patch' translates to the merge request review.


[0] it's on my TODO list (TM)

>Andrea Bolognani / Red Hat / Virtualization
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200403/30166d7a/attachment-0001.sig>

More information about the libvir-list mailing list