[libvirt PATCH] github: enable lockdown of issues and merge requests

Daniel P. Berrangé berrange at redhat.com
Mon Apr 6 08:57:46 UTC 2020


On Fri, Apr 03, 2020 at 07:23:03PM +0200, Andrea Bolognani wrote:
> On Fri, 2020-04-03 at 11:38 +0100, Daniel P. Berrangé wrote:
> > +++ b/.github/lockdown.yml
> > @@ -0,0 +1,36 @@
> > +pulls:
> > +  comment: |
> > +    Thank you for your interest in the libvirt project.
> > +
> > +    Since this repository is a read-only mirror of the project's
> >      master repostory hosted on GitLab, merge requests opened here
> >      are not processed.
> 
> Maybe s/merge/pull/ here? Since we're adding a comment on GitHub and
> targeting GitHub users when doing so, it might be more appropriate to
> use the GitHub term.
> 
> Everything else looks good, but there's the obvious caveat that we
> can't merge the commit as-is until we have actually moved to GitLab.

Now that we've got the release out of the way, I want to do the switch
to GitLab as the master repository in the next day or two. I've got
everything prepared that we need now I believe. Must just flip the repo
mirror job into reverse and make the old repos read-only to current
maintainers to prevent acceidental pushes to the wrong place. I'll plan
to do this on Tuesday, approx 1200 GMT give/take an hour.  Maintainers
will merely need to update their git origin URL, nothing more.

Although this lockdown message suggests opening a merge request, and
we wouldn't immediately be using merge requests for libvirt.git, I
dont think that's a problem. The number of people who'll see and follow
this lockdown message is going to be pretty small to start with at least,
so its not a big deal if we tell them to use MR right now.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list