[PATCH] libxl: fix crash when initializing driver

Ján Tomko jtomko at redhat.com
Mon Apr 6 09:19:56 UTC 2020


On a Friday in 2020, Jim Fehlig wrote:
>Commit 54a401af478 split out DriverConfigInit from DriverConfigNew, but
>then called it a bit late from libxlStateInitialize. The cfg is used in
>libxlDriverConfigLoadFile and when uninitialized results in a crash.
>Calling DriverConfigInit immediately after DriverConfigNew fixes the
>crash.
>

More specifically it's libxlGetAutoballoonConf which depends on
cfg->verInfo being filled if autoballoon is not set in the config file.
I don't have an idea how to neatly split it to maintain the separation
I intended to do in that commit.

>Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>---
> src/libxl/libxl_driver.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200406/97738761/attachment-0001.sig>


More information about the libvir-list mailing list