[libvirt PATCH 13/15] qemu-cgroup: register ext devices when cpu/cpuset controller are missing

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Mon Apr 6 21:27:10 UTC 2020


From: Marc-André Lureau <marcandre.lureau at redhat.com>

External devices registration can add processes to the process group,
which allows basic process management or other tuning.

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
---
 src/qemu/qemu_cgroup.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index cec0a03889..c288519e62 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -1127,15 +1127,6 @@ qemuSetupCgroupForExtDevices(virDomainObjPtr vm,
         priv->cgroup == NULL)
         return 0; /* Not supported, so claim success */
 
-    /*
-     * If CPU cgroup controller is not initialized here, then we need
-     * neither period nor quota settings.  And if CPUSET controller is
-     * not initialized either, then there's nothing to do anyway.
-     */
-    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
-        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
-        return 0;
-
     if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                            false, &cgroup_temp) < 0)
         goto cleanup;
-- 
2.26.0.rc2.42.g98cedd0233




More information about the libvir-list mailing list