[libvirt PATCH 01/39] cpu_x86: Drop noTSX hint for incompatible CPUs

Ján Tomko jtomko at redhat.com
Tue Apr 7 06:39:10 UTC 2020

On a Friday in 2020, Jiri Denemark wrote:
>The hint was introduced a long time ago when broken TSX implementation
>was found in Haswell and Broadwell CPUs. Since then many more CPUs with
>TSX were introduced and and disabled due to TAA vulnerability.
>Thus the hint is not very useful and I think removing it is a better
>choice then updating it to cover all current noTSX models.

This partially reverts:
commit 7f127ded657b24e0e55cd5f3539ef5b2dc935908
     cpu: Rework cpuCompare* APIs

>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> src/cpu/cpu_x86.c | 42 ++++++------------------------------------
> 1 file changed, 6 insertions(+), 36 deletions(-)
>diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
>index ce15bb0454..eeb16c2763 100644
>--- a/src/cpu/cpu_x86.c
>+++ b/src/cpu/cpu_x86.c
>@@ -1937,7 +1937,6 @@ virCPUx86Compare(virCPUDefPtr host,
>                  bool failIncompatible)
> {
>     virCPUCompareResult ret = VIR_CPU_COMPARE_ERROR;
>-    virCPUx86MapPtr map;
>     virCPUx86ModelPtr model = NULL;

model is unused after this patch (that will cause a build error with
clang after the g_auto conversion later in the series)

>     char *message = NULL;

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200407/5ac783b4/attachment-0001.sig>

More information about the libvir-list mailing list