[libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

Daniel P. Berrangé berrange at redhat.com
Tue Apr 7 09:53:50 UTC 2020

On Tue, Apr 07, 2020 at 11:50:31AM +0200, Ján Tomko wrote:
> On a Monday in 2020, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > 
> > Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the
> > presence of machine1 service"), the code checks for systemd1
> > registration. Not totally unreasonable, but that seems odd since we
> > actually check machined presence in this function.
> That is intentional.
> We only count the systemd-based services as really activatable
> if systemd1 is already registered.
> On some Frankenstein'd Gentoo systems with systemd installed
> but not started, the services were showing up as activatable
> but failed with obscure errors.

We could benefit from a comment to this effect being added to
the code, as one of my own local changes makes much the same
fix as Marc-Andre's

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list