[libvirt PATCH] docs: add 'edit this page' link to footer of every page

Ján Tomko jtomko at redhat.com
Thu Apr 9 08:38:41 UTC 2020


On a Wednesday in 2020, Daniel P. Berrangé wrote:
>On Wed, Apr 08, 2020 at 06:08:59PM +0200, Ján Tomko wrote:
>> On a Wednesday in 2020, Daniel P. Berrangé wrote:
>> > This gives a way to contribute
>> > content that is arguably easier than our wiki which requires manual
>> > account creation, while this will also benefit from maintainer review.
>> >
>> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> > ---
>> > docs/Makefile.am | 5 +++++
>> > docs/page.xsl    | 7 +++++++
>> > docs/site.xsl    | 1 +
>> > docs/subsite.xsl | 1 +
>> > 4 files changed, 14 insertions(+)
>> >
>> > @@ -150,6 +151,12 @@
>> >           </div>
>> >         </div>
>> >         <div id="footer">
>> > +          <div id="contact">
>> > +            <h3>Contribute</h3>
>> > +            <ul>
>> > +              <li><a href="https://gitlab.com/libvirt/libvirt/-/blob/master/docs/{$pagesrc}">edit this page</a></li>
>>
>> Consider s/blob/edit/ to go directly to the editing page, at the cost of
>> showing the gitlab login page instead of the source file to users who
>> aren't logged in.
>
>That URL change only makes a difference for the few of us who have
>direct commit privileges to libvirt. For anyone else, if they
>follow the /edit/ link, they'll get redirected to the /blob/
>linnk again, and prompted to fork the repo.

Ah, right. I tried it on your fork of a repo that I also forked,
so the message about forking did not show up for me.

Jano

>Given that /edit/
>has the downside of showing the login screen, and the main
>target audience is 3rd party people, not main libvirt maintrainers,
>I think we can just stick with /blob/
>
>Regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200409/353a9cb9/attachment-0001.sig>


More information about the libvir-list mailing list