[PATCH 4/5] doc: rng schemas and html doc for rbd namespace attribute

[Jason Dillaman]

On Wed, Apr 8, 2020 at 5:06 AM Han Han <hhan at redhat.com> wrote:

> Signed-off-by: Han Han <hhan at redhat.com>
> ---
>  docs/formatdomain.html.in     | 5 +++++
>  docs/schemas/domaincommon.rng | 3 +++
>  2 files changed, 8 insertions(+)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index d56600dc..06e1a7ee 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -3118,6 +3118,11 @@
>                (<span class="since">Since 6.2.0</span>)
>                </p>
>
> +              <p>For protocol <code>rbd</code>, an optional attribute
> +              <code>namespace</code> specifies the namespace of a rbd
> pool.
> +              (<span class="since">Since 6.3.0 and QEMU 5.0.0</span>)
> +              </p>
> +
>                <p>For "iscsi" (<span class="since">since 1.0.4</span>), the
>                <code>name</code> attribute may include a logical unit
> number,
>                separated from the target's name by a slash (e.g.,
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index dcf2e09d..294ade34 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1762,6 +1762,9 @@
>          <optional>
>            <attribute name="name"/>
>          </optional>
> +        <optional>
> +          <attribute name="namespace"/>
> +        </optional>
>

My only concern about this patchset is how the "name" attribute is
overloaded (historically) to include both the RBD pool and image name. Now
if the RBD namespace is separated out to its own optional attribute, it
requires constructing an invalid "<pool>/<image-name>" name attribute.  Can
the pool be separated out to its own attribute as well  (i.e. <source ...
image="image1" pool="rbd" namespace="ns1"...>) and keep a deprecated
backwards compatible "name='pool/image'" attribute that doesn't support
namespaces? The QAPI already has the pool and image as separate attributes.


>          <zeroOrMore>
>            <ref name="diskSourceNetworkHost"/>
>          </zeroOrMore>
> --
> 2.25.0
>
>

-- 
Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200416/7bd7ba8b/attachment-0001.htm>