[PATCH 3/4] tests: Tests for io mode io_uring
Peter Krempa
pkrempa at redhat.com
Mon Apr 20 07:44:17 UTC 2020
On Sat, Apr 18, 2020 at 23:57:53 +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan at redhat.com>
> ---
> tests/qemublocktest.c | 1 +
> ...le-backing_basic-aio_io_uring-srconly.json | 44 +++++++++++++
> .../file-backing_basic-aio_io_uring.json | 66 +++++++++++++++++++
> .../file-backing_basic-aio_io_uring.xml | 47 +++++++++++++
> .../disk-aio-io_uring.x86_64-latest.args | 40 +++++++++++
> tests/qemuxml2argvdata/disk-aio-io_uring.xml | 30 +++++++++
> tests/qemuxml2argvtest.c | 1 +
> .../disk-aio-io_uring.x86_64-latest.xml | 39 +++++++++++
> tests/qemuxml2xmltest.c | 1 +
> 9 files changed, 269 insertions(+)
> create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring-srconly.json
> create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring.json
> create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring.xml
> create mode 100644 tests/qemuxml2argvdata/disk-aio-io_uring.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-aio-io_uring.xml
> create mode 100644 tests/qemuxml2xmloutdata/disk-aio-io_uring.x86_64-latest.xml
The series doesn't pass 'make check' at this point since the RNG schema
is fixed only in commit 4. So the patches need to be reordered.
> diff --git a/tests/qemuxml2argvdata/disk-aio-io_uring.xml b/tests/qemuxml2argvdata/disk-aio-io_uring.xml
> new file mode 100644
> index 00000000..b067cc72
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/disk-aio-io_uring.xml
> @@ -0,0 +1,30 @@
> +<domain type='qemu'>
> + <name>QEMUGuest1</name>
> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
> + <memory unit='KiB'>219100</memory>
> + <currentMemory unit='KiB'>219100</currentMemory>
> + <vcpu placement='static'>1</vcpu>
> + <os>
> + <type arch='x86_64' machine='pc'>hvm</type>
> + <boot dev='hd'/>
> + </os>
> + <clock offset='utc'/>
> + <on_poweroff>destroy</on_poweroff>
> + <on_reboot>restart</on_reboot>
> + <on_crash>destroy</on_crash>
> + <devices>
> + <emulator>/usr/bin/qemu-system-x86_64</emulator>
> + <disk type='block' device='disk'>
> + <driver name='qemu' type='qcow2' io='io_uring'/>
> + <source dev='/dev/HostVG/QEMUGuest1'/>
> + <target dev='hda' bus='ide'/>
Please use virtio-blk/scsi here. Using a high-performance backend with IDE
emulation frontend doesn't make much sense and gives bad examples.
> + <address type='drive' controller='0' bus='0' target='0' unit='0'/>
> + </disk>
> + <controller type='usb' index='0'/>
> + <controller type='ide' index='0'/>
> + <controller type='pci' index='0' model='pci-root'/>
> + <input type='mouse' bus='ps2'/>
> + <input type='keyboard' bus='ps2'/>
> + <memballoon model='virtio'/>
> + </devices>
> +</domain>
After reordering:
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list