[PATCH 2/3] virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal

Ján Tomko jtomko at redhat.com
Mon Apr 20 08:10:03 UTC 2020

On a Monday in 2020, Michal Privoznik wrote:
>I've just got a new machine and I'm still converging on the
>kernel config. Anyway, since I don't have enabled any of SRIO-V
>drivers, my kernel doesn't have NET_DEVLINK enabled (i.e.
>virNetDevGetFamilyId() returns 0). But this makes nodedev driver
>ignore all intefaces, because when enumerating all devices via


>udev, the control reaches virNetDevSwitchdevFeature() eventually
>and subsequently virNetDevGetFamilyId() which 'fails'. Well, it's
>not really a failure - the virNetDevSwitchdevFeature() stub
>simply returns 0.
>Also, move the call a few lines below, just around the place
>where it's needed.
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> src/util/virnetdev.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200420/5d3c9c81/attachment-0001.sig>

More information about the libvir-list mailing list