[libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

[Daniel P. Berrangé]

On Mon, Apr 20, 2020 at 03:00:37PM +0200, Andrea Bolognani wrote:
> CentOS 7 is missing perl-generators, as explained in the comment,
> but this limitation does not apply to CentOS 8.

The comment is wrong


> diff --git a/jenkins/projects/libvirt-tck.yaml b/jenkins/projects/libvirt-tck.yaml
> index fcdea98..c0fb1f7 100644
> --- a/jenkins/projects/libvirt-tck.yaml
> +++ b/jenkins/projects/libvirt-tck.yaml
> @@ -4,6 +4,7 @@
>      # CentOS 7 doesn't include perl-generators, which is necessary to
>      # build libvirt-tck

perl-Sys-Virt-TCK.spec.PL says

%if 0%{?fedora} || 0%{?rhel} > 7
BuildRequires: perl-interpreter
BuildRequires: perl-generators
%endif

perl-generators is not a module ever used by code, it is an invention of the
RPM packaging, to get the automatic  Reqiures/Provides lines added. So the
fact that it doesn't exist on RHEL-7 is simply because it is part of another
RPM instead (redhat-rpm-config IIRC)

>      machines:
> +      - libvirt-centos-8
>        - libvirt-debian-9
>        - libvirt-debian-10
>        - libvirt-fedora-30
> @@ -22,6 +23,7 @@
>        - perl-modulebuild-rpm-job:
>            parent_jobs: 'libvirt-tck-check'
>            machines:
> +            - libvirt-centos-8
>              - libvirt-fedora-30
>              - libvirt-fedora-31
>              - libvirt-fedora-rawhide
> -- 
> 2.25.3
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|