[PATCH 1/3] udevRemoveOneDevice: Unlock node device obj upon return

Ján Tomko jtomko at redhat.com
Mon Apr 20 15:43:30 UTC 2020

On a Monday in 2020, Michal Privoznik wrote:
>When removing a node device object from the internal list the
>udevRemoveOneDevice() function does plain unref over the object.
>This is not sufficient. If there is another thread that's waiting
>for the object lock it will wait forever.

I presume nobody wanted to lock that device before - this seems to have
been there even before the conversion to virObjectLockable in
commit dae23ec3456011f86086db76d45d8d0d266f7b9f

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> src/node_device/node_device_udev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200420/22d2284b/attachment-0001.sig>

More information about the libvir-list mailing list