[libvirt PATCH] virsh: Fix return code for dump and migrate
abologna at redhat.com
Wed Apr 22 07:36:07 UTC 2020
On Tue, 2020-04-21 at 18:25 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 21, 2020 at 07:15:00PM +0200, Andrea Bolognani wrote:
> > When the job monitoring logic was refactored, these two commands
> > were not converted properly and the result is that a successful
> > dump or migration (char '0') would be reported as a failed one
> > (int 48) instead.
> > Fixes: dc0771cfa2e78ffecd7c8234538ee548748d7bef
> > Reported-by: Brian Rak <brak at gameservers.com>
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > ---
> > tools/virsh-domain.c | 10 +++-------
> > 1 file changed, 3 insertions(+), 7 deletions(-)
> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Thanks, pushed now. And thanks again to Brian for reporting the issue
and tracking it down!
Do you think we should backport this to the 6.1 and 6.2 mainteinance
branches? It fixes a fairly bad regression... But I'm not very
familiar with how we handle those branches.
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list