[libvirt-ci RFC PATCH 00/13] Introduce a new global TOML config file for lcitool

Erik Skultety eskultet at redhat.com
Wed Apr 22 13:28:18 UTC 2020

This series is trying to consolidate the number of config files we currently
recognize under ~/.config/lcitool to a single global TOML config file. Thanks
to this effort we can expose more seetings than we previously could which will
come handy in terms of generating cloudinit images for OpenStack.

Patches 1-4 patches are just a little extra - not heavily related to the series
See patch 5/13 why TOML was selected.

Erik Skultety (13):
  requirements: Introduce a requirements.txt file
  lcitool: Decrease the indent when creating a tempdir for initrd
  lcitool: Prefer tempfile's native wrappers over low level primitives
  lcitool: Use a temporary JSON file to pass extra variables
  config: Introduce a new global config.toml configuration file
  lcitool: Introduce methods to load and validate the TOML config
  lcitool: Drop the get_flavor() method
  lcitool: Drop the get_root_password_file() method
  lcitool: Drop the gitlab-related getter methods
  lcitool: Use d.update() on extra_vars for options coming from the
  config: Move the virt-install settings from install.yml to the config
  lcitool: Use the config install options rather than install facts
  guests: README: Document the existence and usage of config.toml

 config.toml                              |  43 +++++
 guests/README.markdown                   |  19 +-
 guests/lcitool                           | 235 +++++++++++------------
 guests/playbooks/update/tasks/gitlab.yml |   2 -
 guests/playbooks/update/tasks/users.yml  |   2 +-
 requirements.txt                         |   3 +
 6 files changed, 175 insertions(+), 129 deletions(-)
 create mode 100644 config.toml
 create mode 100644 requirements.txt


More information about the libvir-list mailing list