[PATCH v2 1/2] conf: Add <lease/> option for <dhcp/> settings

[Julio Faracco]

Em qua., 22 de abr. de 2020 às 10:45, Daniel Henrique Barboza
<danielhb413 at gmail.com> escreveu:
>
>
>
> On 4/22/20 9:22 AM, Julio Faracco wrote:
> > Hi Daniel,
> >
> > Thanks for reviewing. :-)
>
>
> Np, glad to be of assistance
>
>
> > IMHO, I don't like to join them in one single patch because it is hard
> > to review.
>
>
> Hmm, reading this I believe that the tests would pass after applying patch
> 2/2 then (didn't try).
>
> > I know that others have a different opinion (and it is good).
>
>
> The way you split the patch series is up to debate and so on and so
> forth. The issue here is that every single patch must pass 'make check',
> as said in docs/hacking.rst in the "Preparing patches" session:
>
> ----------
> If you're going to submit multiple patches, the automated tests
> must pass **after each patch**, not just after the last one.
> ----------

Yes, I usually keep a post commit hook, but I (unfortunately) moved to
another Linux distro without my customization. Sorry about that.

There is a memory leak also. I need to resend this series anyway.

>
> You'll need to think in a way of splitting the series that allows each
> patch to pass 'make check' in its own.
>
>
> Thanks,
>
>
> DHB
>