[PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

[Peter Krempa]

On Fri, Apr 24, 2020 at 09:52:00 -0500, Eric Blake wrote:
> On 4/24/20 4:24 AM, Peter Krempa wrote:
> > The implementation was never finished in libvirt. Remove it.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >   src/util/virstoragefile.c | 19 ++-----------------
> >   1 file changed, 2 insertions(+), 17 deletions(-)
> 
> Shouldn't we at least recognize if there is a qcow2 file with the extension
> header set, at which point we can error out and tell the user their image is
> unsupported, rather than trying to use it without the data file?

I don't think it's scalable to do so unless qemu exposes a whitelist of
supported extensions we can declare we support. Otherwise we are
band-aiding stuff we lear that exists and ignore any other extensions.