[libvirt PATCH 2/2] CONTRIBUTING: Include note about build system tools

[Daniel P. Berrangé]

On Mon, Apr 27, 2020 at 01:15:08PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-04-27 at 12:03 +0100, Daniel P. Berrangé wrote:
> > On Mon, Apr 27, 2020 at 12:54:21PM +0200, Andrea Bolognani wrote:
> > > +Note that, for the RHEL-based case, if you're on a machine where you
> > > +haven't done any C development before, you will probably also need
> > > +to run
> > > +
> > > +::
> > > +
> > > +   $ sudo dnf groupinstall "C Development Tools and Libraries"
> > 
> > This group doesn't exist on any RHEL distro, and dnf itself only
> > exists in RHEL >= 8.  I htink we should be just listing the packages
> > we need explicitly rather than relying on a group whose name & contents
> > change over time.
> 
> I expect most people doing development work on libvirt are using
> Fedora rather than RHEL, and I really don't want this document to
> become too verbose or duplicate too much information that's already
> available elsewhere... If we can cover ~90% of potential users with
> just a few commands, I think that's preferable.

Just listing the extra packages is simpler than the group name.

   dnf install gcc make automake libtool autoconf rpm-build



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|