[libvirt-ci PATCH 02/13] lcitool: Decrease the indent when creating a tempdir for initrd injection

Andrea Bolognani abologna at redhat.com
Mon Apr 27 14:27:55 UTC 2020


On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote:
> The 'with' statement doesn't define a new code block [1], thus no local
> namespace is created. Therefore, we can still access the @content
> variable outside of the 'with' block. So, there's really no need to
> hold the @initrd_template file open longer than necessary (not that it
> would be a big deal anyway).
> 
> [1] https://docs.python.org/3.7/reference/executionmodel.html
> 
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  guests/lcitool | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list