[PATCH 0/4] move validation of virtio options

[Michal Privoznik]

On 4/23/20 3:15 PM, Bjoern Walk wrote:
> Move validation of virtio options (iommu, ats, packed) from QEMU command
> line generation to domain validation. As a drive-by, increase the
> granularity of tests for virtio options.
> 
> Bjoern Walk (4):
>    tests: use latest caps for virtio-options test
>    tests: more fine-granular tests for virtio-options
>    qemu: move virtio capability validation
>    qemu: command: make qemuBuildVirtioOptionsStr void
> 
>   src/qemu/qemu_command.c                       |  59 +++-------
>   src/qemu/qemu_validate.c                      |  70 +++++++++++-
>   .../virtio-options-controller-ats.args        |  32 ++++++
>   .../virtio-options-controller-ats.xml         |  38 +++++++
>   .../virtio-options-controller-iommu.args      |  34 ++++++
>   .../virtio-options-controller-iommu.xml       |  38 +++++++
>   .../virtio-options-controller-packed.args     |  32 ++++++
>   .../virtio-options-controller-packed.xml      |  38 +++++++
>   .../virtio-options-disk-ats.args              |  36 +++++++
>   .../virtio-options-disk-ats.xml               |  34 ++++++
>   .../virtio-options-disk-iommu.args            |  36 +++++++
>   .../virtio-options-disk-iommu.xml             |  34 ++++++
>   .../virtio-options-disk-packed.args           |  36 +++++++
>   .../virtio-options-disk-packed.xml            |  34 ++++++
>   .../virtio-options-fs-ats.args                |  34 ++++++
>   .../virtio-options-fs-ats.xml                 |  34 ++++++
>   .../virtio-options-fs-iommu.args              |  34 ++++++
>   .../virtio-options-fs-iommu.xml               |  34 ++++++
>   .../virtio-options-fs-packed.args             |  34 ++++++
>   .../virtio-options-fs-packed.xml              |  34 ++++++
>   .../virtio-options-input-ats.args             |  30 ++++++
>   .../virtio-options-input-ats.xml              |  30 ++++++
>   .../virtio-options-input-iommu.args           |  30 ++++++
>   .../virtio-options-input-iommu.xml            |  30 ++++++
>   .../virtio-options-input-packed.args          |  30 ++++++
>   .../virtio-options-input-packed.xml           |  30 ++++++
>   .../virtio-options-memballoon-ats.args        |  28 +++++
>   .../virtio-options-memballoon-ats.xml         |  23 ++++
>   .../virtio-options-memballoon-iommu.args      |  28 +++++
>   .../virtio-options-memballoon-iommu.xml       |  23 ++++
>   .../virtio-options-memballoon-packed.args     |  28 +++++
>   .../virtio-options-memballoon-packed.xml      |  23 ++++
>   .../virtio-options-net-ats.args               |  34 ++++++
>   .../virtio-options-net-ats.xml                |  34 ++++++
>   .../virtio-options-net-iommu.args             |  34 ++++++
>   .../virtio-options-net-iommu.xml              |  34 ++++++
>   .../virtio-options-net-packed.args            |  34 ++++++
>   .../virtio-options-net-packed.xml             |  34 ++++++
>   .../virtio-options-rng-ats.args               |  32 ++++++
>   .../virtio-options-rng-ats.xml                |  32 ++++++
>   .../virtio-options-rng-iommu.args             |  34 ++++++
>   .../virtio-options-rng-iommu.xml              |  32 ++++++
>   .../virtio-options-rng-packed.args            |  32 ++++++
>   .../virtio-options-rng-packed.xml             |  32 ++++++
>   .../virtio-options-video-ats.args             |  34 ++++++
>   .../virtio-options-video-ats.xml              |  36 +++++++
>   .../virtio-options-video-iommu.args           |  34 ++++++
>   .../virtio-options-video-iommu.xml            |  36 +++++++
>   .../virtio-options-video-packed.args          |  34 ++++++
>   .../virtio-options-video-packed.xml           |  36 +++++++
>   .../virtio-options.x86_64-latest.args         |  69 ++++++++++++
>   tests/qemuxml2argvdata/virtio-options.xml     |   5 +-
>   tests/qemuxml2argvtest.c                      | 101 ++++++++++++++++--
>   .../virtio-options.x86_64-latest.xml          |   1 +
>   tests/qemuxml2xmltest.c                       |  16 +--
>   55 files changed, 1818 insertions(+), 70 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-controller-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-disk-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-fs-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-input-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-net-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-rng-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-ats.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-ats.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-iommu.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-iommu.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-packed.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-options-video-packed.xml
>   create mode 100644 tests/qemuxml2argvdata/virtio-options.x86_64-latest.args
>   create mode 120000 tests/qemuxml2xmloutdata/virtio-options.x86_64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

and pushed.

Michal