[PATCH 1/3] Improve blockpull man entry

Eric Blake eblake at redhat.com
Tue Apr 28 14:32:57 UTC 2020

On 4/28/20 9:19 AM, Sebastian Mitterle wrote:
>> So bandwidth indeed is a positional argument. Since all of the manpage
>> uses the syntax we've had here originally fixing just this place would
>> be wrong. The only fix that should be done here is to group the --bytes
>> flag under bandwidth as specifying --bytes is mandatory.
> I think there's misunderstanding:
> # virsh blockpull fedora vda vda[1]

We should really encourage users to properly quote their command line to 
avoid unintentional globbing:

# virsh blockpull fedora vda "vda[1]"

(Otherwise, if I 'touch vda1', the unquoted command will see the 
argument 'vda1')

> error: Scaled numeric value 'vda[1]' for <--bandwidth> option is
> malformed or out of range
> # virsh blockpull fedora vda 1024 vda[1]
> Block Pull started
> I'll change to [bandwidth [--bytes] [base]]

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

More information about the libvir-list mailing list