[PATCH V3 5/5] cpu: Introduce getHost support for ARM CPU driver

Zhenyu Zheng zhengzhenyulixi at gmail.com
Wed Apr 29 08:03:19 UTC 2020


Hi Jiri,

Thanks alot for the help, I've updated the series to v4 and also attached
pipeline results for each patch as suggested.

BR,

On Tue, Apr 28, 2020 at 7:11 PM Zhenyu Zheng <zhengzhenyulixi at gmail.com>
wrote:

> Thanks alot I will check again about the patch series.
>
> On Tue, Apr 28, 2020 at 6:39 PM Jiri Denemark <jdenemar at redhat.com> wrote:
>
>> On Wed, Apr 22, 2020 at 15:14:01 +0800, Zhenyu Zheng wrote:
>> >  gitlab CI testing as suggested:
>> > https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317
>>
>> Sending results of CI pipeline makes sense only when the code submitted
>> for CI is exactly the same as submitted for review. You should just push
>> the branch with your local changes to your gitlab repo rather than
>> somehow combining all patches you sent into one or even make additional
>> changes.
>>
>> Apparently the patch pushed to gitlab is a bit different than this
>> series as this series cannot be compiled due to a missing "return NULL;"
>> line in patch 4/5.
>>
>> Anyway, I'm trying to get some ARM hosts and hoping to find at least one
>> where your series would actually detect the host CPU to see how this
>> works in real life and to confirm (or not) my suspicions. No need to
>> resent this series to fix the compilation error yet, I'll fix it myself
>> for testing.
>>
>> Thank you for your patience.
>>
>> Jirka
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200429/3f6cb7aa/attachment-0001.htm>


More information about the libvir-list mailing list