[libvirt-python PATCH 1/3] test: workaround missing VIR_TYPED_PARAM enums in API definition

Daniel P. Berrangé berrange at redhat.com
Thu Apr 30 11:54:05 UTC 2020


On Thu, Apr 30, 2020 at 10:18:31AM +0200, Andrea Bolognani wrote:
> On Wed, 2020-04-29 at 14:36 +0100, Daniel P. Berrangé wrote:
> > On Ubuntu 1804 with libvirt 4.0.0 libvirt-python build fails
> 
> s/1804/18.04/
> 
> > +++ b/sanitytest.py
> > @@ -73,7 +73,11 @@ for n in second_pass:
> > -    if type(val) != int:
> > +    # Version 4.0.0 was broken as missing VIR_TYPED_PARAM enums
> > +    # constants. This is harmless from POV of validating API
> > +    # coverage so ignore this error.
> > +    if (type(val) != int and
> > +        not val.startswith("VIR_TYPED_PARAM_")):
> 
> Should this comment also contain a reference to Ubuntu 18.04? Or is
> the issue present in any build of libvirt 4.0.0?

Any 4.0.0

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list